Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP implementation of writable canned queries #703

Closed
wants to merge 91 commits into from
Closed

WIP implementation of writable canned queries #703

wants to merge 91 commits into from

Conversation

simonw
Copy link
Owner

@simonw simonw commented Mar 21, 2020 •
edited
Loading

Refs #698.

@simonw simonw force-pushed the writable-canned branch from c06e180 to b07fd41 Compare April 2, 2020 22:10
@simonw
Copy link
Owner Author

simonw commented Apr 2, 2020

I'm going to split canned queries out from arbitrary queries to make the code easier to follow.

simonw added 2 commits April 27, 2020 15:02
@simonw
Remove 'Serve!' line from serve CLI output
e37f407 
It wasn't adding anything, and it was confusing when run in
conjunction with the new config directory mode from #731
@simonw
First working version of writable canned queries, refs #698
18c5bd1
@simonw
Copy link
Owner Author

simonw commented Apr 29, 2020

Adding some still-to-do items to a checklist in the description.

simonw
simonw commented Apr 29, 2020
View reviewed changes
datasette/views/database.py Outdated
write_ok = await self.ds.databases[database].execute_write(
sql, params, block=True
)
return self.redirect(request, request.path + '?_success=Query+executed_successfully')
Copy link
Owner Author

@simonw simonw Apr 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing ?_success like this isn't necessarily the best approach. Potential improvements include:

  • Signing this message so it can't be tampered with (I could generate a signing secret on startup)
  • Using a cookie with a temporary flash message in it instead
  • Using HTML5 history API to remove the ?_success= from the URL bar when the user lands on the page

If I add an option to redirect the user to another page after success I may need a mechanism to show a flash message on that page as well, in which case I'll need a general flash message solution that works for any page.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could add itsdangerous as a signing dependency, which delightfully has zero dependencies of its own: https://pypi.org/project/itsdangerous

simonw and others added 22 commits April 30, 2020 11:31
@simonw
Changelog badge
d18086a
@simonw
Directory configuration mode supports metadata.yaml, closes #747
1d91ab7
@simonw
Documentation for #747
cf2d547
@simonw
Re-arranged full-text search docs
4df1b4d 
Also documented ?_searchmode=raw - closes #748
@simonw
Added 'not like' table filter, refs #750
b3aa5f4
@simonw
Started pattern portfolio at /-/patterns, refs #151
cef23e8
@simonw
Add badges to documentation index
d996d41
@dependabot-preview
Update aiofiles requirement from ~=0.4.0 to >=0.4,<0.6 (#725)
985e594 
Refs #754

Updates the requirements on [aiofiles](https://github.com/Tinche/aiofiles) to permit the latest version.
- [Release notes](https://github.com/Tinche/aiofiles/releases)
- [Commits](Tinche/aiofiles@v0.4.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Update mergedeep requirement from ~=1.1.1 to >=1.1.1,<1.4.0 (#728)
e232f77 
Updates the requirements on [mergedeep](https://github.com/clarketm/mergedeep) to permit the latest version.
- [Release notes](https://github.com/clarketm/mergedeep/releases)
- [Commits](clarketm/mergedeep@v1.1.1...v1.3.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Update janus requirement from ~=0.4.0 to >=0.4,<0.6 (#734)
109c5a4 
Updates the requirements on [janus](https://github.com/aio-libs/janus) to permit the latest version.
- [Release notes](https://github.com/aio-libs/janus/releases)
- [Changelog](https://github.com/aio-libs/janus/blob/master/CHANGES.rst)
- [Commits](aio-libs/janus@v0.4.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Update jinja2 requirement from ~=2.10.3 to >=2.10.3,<2.12.0 (#722)
aa064de 
Updates the requirements on [jinja2](https://github.com/pallets/jinja) to permit the latest version.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/master/CHANGES.rst)
- [Commits](pallets/jinja@2.10.3...2.11.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Update pytest requirement from ~=5.2.2 to >=5.2.2,<5.5.0 (#721)
c91fb9e 
Updates the requirements on [pytest](https://github.com/pytest-dev/pytest) to permit the latest version.
- [Release notes](https://github.com/pytest-dev/pytest/releases)
- [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/pytest@5.2.2...5.4.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@cldellow
asgi: check raw_path is not None (#719)
dbd2d70 
The ASGI spec
(https://asgi.readthedocs.io/en/latest/specs/www.html#http) seems to
imply that `None` is a valid value, so we need to check the value
itself, not just whether the key is present.

In particular, the [mangum](https://github.com/erm/mangum) adapter
passes `None` for this key.
@dependabot-preview
Update beautifulsoup4 requirement from ~=4.8.1 to >=4.8.1,<4.10.0 (#720)
707fe03 
Updates the requirements on [beautifulsoup4](http://www.crummy.com/software/BeautifulSoup/bs4/) to permit the latest version.

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Update pytest-asyncio requirement from ~=0.10.0 to >=0.10,<0.13 (#753)
b314e08 
Updates the requirements on [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) to permit the latest version.
- [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases)
- [Commits](pytest-dev/pytest-asyncio@v0.10.0...v0.12.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@simonw
Fixed pytest warning about TestClient class
450d2e2
@simonw
Consistently return charset utf-8, closes #752
9424687
@simonw
Fixed rogue output in tests, closes #755
cc872b1
@simonw
Documented installation using pipx, closes #756
7e2bb31
@simonw
Move pip/pipx to top of installation instructions
0cdf111 
Less intimidating than Docker, hopefully.
@simonw
Removed note about virtual environments
9212f0c 
Simplifies things now that we also talk about pipx.
@simonw
Allow specific pragma functions, closes #761
0784f2e
simonw added 19 commits May 30, 2020 07:38
@simonw
_ prefix for many private methods of Datasette, refs #576
012c769
@simonw
Moved request tests to test_internals_request.py
de1cde6
@simonw
Improved documentation for RequestParameters class
5ae14c9
@simonw
Re-arranged internals documentation
3c5afae 
Request is more useful to most people than Database.
@simonw
Added test for db.mtime_ns
4d798ca
@simonw
Removed db.get_outbound_foreign_keys method
124acf3 
It duplicated the functionality of db.foreign_keys_for_table.
@simonw
Documentation for Database introspection methods, closes #684
c4fbe50 
Refs #576
@simonw
actor_from_request and permission_allowed hookspecs, refs #699
060a567
@simonw
Implemented actor_from_request with tests, refs #699
461c828 
Also added datasette argument to permission_allowed hook
@simonw
Implemented datasette.permission_allowed(), refs #699
9315bac
@simonw
Added /-/actor.json - refs #699
1fc6cee 
Also added JSON highlighting to introspection documentation.
@simonw
datasette.sign() and datasette.unsign() methods, refs #785
fa27e44
@simonw
Docs for --secret/DATASETTE_SECRET - closes #785
7690d5b
@simonw
--root option and /-/auth-token view, refs #784
9f3d4ab
@simonw
Default actor_from_request hook supporting ds_actor signed cookie
57cf513 
Refs #784, refs #699
@simonw
Added /-/permissions debug tool, closes #788
dfdbdf3 
Also started the authentication.rst docs page, refs #786.

Part of authentication work, refs #699.
@simonw
First working version of writable canned queries, refs #698
5b252a2
@simonw
Applied black
ee51e0b
@simonw
Merge branch 'writable-canned' of github.com:simonw/datasette into wr…
61131f1 
…itable-canned
@simonw simonw mentioned this pull request Jun 1, 2020
Closed
@simonw
Copy link
Owner Author

simonw commented Jun 2, 2020

This pull request got too messy. I'm going to abandon this and start a new one.

@simonw simonw closed this Jun 2, 2020
simonw added a commit that referenced this pull request Jun 3, 2020
@simonw
New WIP writable canned queries
49eed3f 
Refs #698. Replaces #703
This was referenced Jun 3, 2020
Merged
Closed
simonw added a commit that referenced this pull request Jun 3, 2020
@simonw
New WIP writable canned queries
9ec5407 
Refs #698. Replaces #703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonw @cldellow