Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add figures for triangles and lozenges #55

Closed
ehmicky opened this issue Mar 24, 2021 · 3 comments · Fixed by #64
Closed

Add figures for triangles and lozenges #55

ehmicky opened this issue Mar 24, 2021 · 3 comments · Fixed by #64

Comments

@ehmicky
Copy link
Collaborator

ehmicky commented Mar 24, 2021

What are your thoughts on adding figures for triangles and lozenges?

They display well on all environments:

Ubuntu 20.10, Gnome terminal:

unix_3

Windows 10, cmd.exe (CP850):

windows_3

I checked on macOS default terminal, and it looks good too 👍

Note: this library is already having one triangle with the play figure, but it might be nice to have it as well as a regular "big triangle pointing to the right" figure.

@sindresorhus
Copy link
Owner

👍

@sindresorhus
Copy link
Owner

Note: this library is already having one triangle with the play figure, but it might be nice to have it as well as a regular "big triangle pointing to the right" figure.

I agree. The play one can just reference this one.

@ehmicky
Copy link
Collaborator Author

ehmicky commented Mar 24, 2021

Fixed by #64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants