-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useFallback
option
#101
Conversation
What's the thinking of having it as a separate method rather than an option for |
3f9e1a7
to
bd7aeb0
Compare
Not thinking about it! That's a better idea. :) I updated the PR to use a |
readme.md
Outdated
// On terminals with Unicode symbols: √︎ check | ||
// On other terminals: √ check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these two show the same symbol since it's using the fallback no matter what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those two lines show the same symbol (the fallback one).
Interesting. I am wondering whether we are looking at different sections. 🤔 Are those the ones in the main example section? Those should be different. The example in the TypeScript types should also show two different symbols. On the other hand, the symbols in the example section for |
Wow, this challenged my sanity but I figured it out. The first symbol was a single character with two codepoints: On VSCode, when I looked up the unicode codepoint, it only showed me the first codepoint. But I used I checked the other files, and it only happened in this example, and its copy in What happened is: the non-fallback tick is So this is now fixed in b051c4e. 🪄 |
Co-authored-by: Sindre Sorhus <[email protected]>
b7ac882
to
0d166ba
Compare
Fixed merged conflict. |
Fixes #100.