Window size detection for Git Bash pager falls back to default values

[Velociraptor45]

Hey there, this is kind of a follow-up to #22. It works fine for the normal git bash window, however when opening e.g. a less pager in that window, it falls back to the default 80/24 values.
I've debugged it and I think I found a bug, but I'd like your confirmation on this.

STR

1. Comment out the following in the index.js to simulate the pager without having to actually have a pager (line 60 is where we'd like to go):
   
2. Temporarily add the following to the bottom of the index.js to execute the size function upon calling the script

var x = terminalSize();
console.log(x);

3. Execute the index.js in a Git Bash and see that it's not returning the correct window size.
   

Possible Solution

The index.js contains this line:

The 'ignore' is duplicated and when I replace the second one with process.stderr, it's working fine.

Resulting in correct window sizes:

Any opinion on this?

[sindresorhus]

It's set to ignored because we don't really want to output any potential error message to the user's stderr, but if there's no other way, I guess we can do it. But only on Windows. So you could make the exec function accept a stdio option (which would default to the current value) and use that in the tput function when on Windows.