Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start_date / bookmark_timestamp does not support a datetime with a timezone offset #83

Closed
y0devv opened this issue Nov 17, 2020 · 1 comment
Closed

Start_date / bookmark_timestamp does not support a datetime with a timezone offset #83

y0devv opened this issue Nov 17, 2020 · 1 comment

Comments

@y0devv
Copy link

y0devv commented Nov 17, 2020

When using a datetime with a timezone offset as either the start_date in config.json, or as a bookmark value a maximum recursion depth exceeded error occurs. This happens on self.initial_state.subtract(seconds=1) in RecentsStream.update_request_params() (so for all recents streams).

This is caused by a bug in Pendulum, which was fixed in 2.1.0
Would it be possible to upgrade the Pendulum version used?
@y0devv y0devv closed this as completed Nov 17, 2020
@y0devv
Copy link
Author

y0devv commented Nov 17, 2020

Duplicate of PR #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@y0devv