Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] minor update to install instructions needed #445

Closed
eburgueno opened this issue Sep 22, 2021 · 7 comments · Fixed by #451
Closed

[Docs] minor update to install instructions needed #445

eburgueno opened this issue Sep 22, 2021 · 7 comments · Fixed by #451

Comments

@eburgueno
Copy link

Docs need updating after #403:

$ shpc config set registry:~/shpc/registry
You cannot use 'set' for a list. Use add/remove instead.

$ shpc config add registry:~/shpc/registry
Warning: Check with shpc config edit - ordering of list can change.
Added registry to ~/shpc/registry
@vsoch
Copy link
Member

vsoch commented Sep 22, 2021

Yes indeed! Would you care to contribute a PR at your convenience?

@eburgueno
Copy link
Author

Can do, thought it seems wasteful to create a commit (and PR) to replace three characters. I'll try looking at the docs a little bit more for other enhancements.

@vsoch
Copy link
Member

vsoch commented Sep 22, 2021

Haha ok (but I don’t think it’s that wasteful!) every little improvement is a step in the right direction, whether addition or subtraction.

@vsoch
Copy link
Member

vsoch commented Nov 4, 2021

@eburgueno just checking in - are you still interested to contribute here?

@eburgueno
Copy link
Author

@vsoch yes, sorry, it's been a busy time. I'll send something shortly.

@vsoch
Copy link
Member

vsoch commented Nov 4, 2021

No worries! See the linked PR for my tiny update to address what you found - if there is more please open a PR, if not apologies for taking me so long to fix that.

@eburgueno
Copy link
Author

That looks just like what I was about to suggest. Thank you for beating me to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants