Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy(NMRExperiment= "wrong name") should warn or error #69

Open
zeehio opened this issue May 7, 2024 · 0 comments
Open

tidy(NMRExperiment= "wrong name") should warn or error #69

zeehio opened this issue May 7, 2024 · 0 comments

Comments

@zeehio
Copy link
Member

zeehio commented May 7, 2024

When using tidy() and passing a missing NMRExperiment name, we get NA values here:

sample_idx <- match(NMRExperiment, names(x))

If there are some NA in sample_idx we should warn about the wrong NMRExperiment values and proceed without the missing samples.

If all values of sample_idx are NA, we should give an error.

The warning/error message should include some valid NMRExperiment values (e.g. head(names(x),2) ) so he/she is guided to fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant