Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error importing bookmarks #18

Closed
ericmoon opened this issue May 4, 2020 · 3 comments
Closed

Error importing bookmarks #18

ericmoon opened this issue May 4, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@ericmoon
Copy link

ericmoon commented May 4, 2020

Running in a docker from hub.docker.com:
sissbruecker/linkding:latest | pulled on 2020-04-07 15:16:52

I can't seem to get the import to work. I've tried exporting from Firefox and Chrome, but always the same error:
An error occurred during bookmark import.

Any pointers to enabling error logs on the docker instance? If I was running the dev setup, I would enable the debug logs in django settings, but want to avoid that, if possible and keep it within docker.

@sissbruecker
Copy link
Owner

Hey @ericmoon , thanks for the report, I'll try to reproduce when I find some time.

As for logging, I just looked at the code and it looks like the error is caught but not logged 😬. So that would have to be improved as well.

@bohrium272
Copy link
Contributor

Hey @sissbruecker I was able to narrow down the issue to KeyError being raised while importing bookmarks, because of the absence of certain attributes in the tag.

I have opened #20 that addresses this

@sissbruecker
Copy link
Owner

The root cause should be fixed thanks to @arpitgogia . I also added some error handling and logging around the importer. I updated the Docker image with the fixes.

I'll close this for now, please reopen if the issue persists.

@sissbruecker sissbruecker added the bug Something isn't working label Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants