Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Uptime Tracker with Dmsg Discovery - deprecate dmsg client monitor #291

Open
0pcom opened this issue Oct 12, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@0pcom
Copy link
Collaborator

0pcom commented Oct 12, 2024

The dmsg client monitor implementation was plagued with issues resulting from the fact that the monitor assumed the dmsg client to be a visor when it may not be a visor.

In order to have an accurate list of dmsg client entries in the dmsg-discovery, we should consider integrating the uptime tracker with the dmsg discovery.

There is no way to verify externally via querying a dmsg client entry that the client is online or not ; because there isn't no single endpoiint like /health served by the client over dmsg.

Its possible that dmsg client entries are currently expired after 5 minutes without re-registration. This logic should be verified. If dead entries are currently present, it would make sense to integrate the uptime tracker and the dmsg discovery.

@0pcom 0pcom added the bug Something isn't working label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant