Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows cmdutil #83

Merged
merged 4 commits into from
Jun 21, 2021
Merged

windows cmdutil #83

merged 4 commits into from
Jun 21, 2021

Conversation

alexadhy
Copy link
Contributor

@alexadhy alexadhy commented May 28, 2021 •
edited
Loading

Related to:

Changes:

  • per platform syslog and syscall signals definition in cmdutil.

How to test this PR:

  • Checkout this PR
  • Checkout Windows build skywire#779
  • go mod edit -replace github.com/skycoin/dmsg=../dmsg
  • build the skywire binaries via make
  • test it on windows

@alexadhy alexadhy changed the title Feature/windows cmdutil [WIP] feature/windows cmdutil May 28, 2021
@alexadhy alexadhy changed the title [WIP] feature/windows cmdutil [WIP] windows cmdutil May 29, 2021
jdknives
jdknives approved these changes May 29, 2021
View reviewed changes
Copy link
Member

@jdknives jdknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant test it but it looks good to me from first glance. Someone needs to verify it builds and works on Windows.

.golangci.yml Show resolved Hide resolved
alexadhy added a commit to alexadhy/skywire that referenced this pull request May 29, 2021
@alexadhy
uses cmdutil from skycoin/dmsg#83
7f1d35d
@alexadhy alexadhy mentioned this pull request May 29, 2021
Merged
2 tasks
i-hate-nicknames
i-hate-nicknames reviewed May 31, 2021
View reviewed changes
Copy link
Contributor

@i-hate-nicknames i-hate-nicknames left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, got just a small comment. (I haven't run it on windows, just read the changes)

cmdutil/signal_context.go Outdated Show resolved Hide resolved
@alexadhy
Copy link
Contributor Author

alexadhy commented Jun 5, 2021

can you merge this?

@alexadhy alexadhy marked this pull request as ready for review June 8, 2021 11:56
@alexadhy alexadhy mentioned this pull request Jun 16, 2021
Merged
7 tasks
@jdknives jdknives merged commit 7a2419d into skycoin:develop Jun 21, 2021
@alexadhy alexadhy changed the title [WIP] windows cmdutil windows cmdutil Jun 21, 2021
@alexadhy alexadhy deleted the feature/windows-cmdutil branch June 25, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-hate-nicknames i-hate-nicknames i-hate-nicknames left review comments

@jdknives jdknives jdknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexadhy @jdknives @i-hate-nicknames