Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests against hardware-wallet/skycoin-api #34

Open
stdevAlDen opened this issue May 9, 2019 · 0 comments
Open

Run tests against hardware-wallet/skycoin-api #34

stdevAlDen opened this issue May 9, 2019 · 0 comments

Comments

@stdevAlDen
Copy link

Feature description
Refactor tests

Describe the feature

It's desired to run this tests battery against hardware-wallet/skycoin-api, as hardware-wallet/skycoin-api have a subset of the libskycoin features it's required to refactor the tests to run all against libskycoin as it' currently and a test subset against hardware-wallet/skycoin-api.

Describe the solution you'd like
Just refactor tests without changing them.

Describe alternatives you've considered
Modifing the library it's not al alternative as this code is auto generated.

Additional context
https://github.com/skycoin/hardware-wallet/issues/84

Possible implementation
This is just about a refactorization, please do not change any thing
@stdevAlDen stdevAlDen changed the title Run tests in against hardware-wallet/skycoin-api Run tests against hardware-wallet/skycoin-api May 9, 2019
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 14, 2019
refactor
af6585c 
move isU8Eq from lib/cgo/tests/testutils/libsky_assert.c to lib/cgo/tests/testutils/common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 14, 2019
refactor
1f3d18d 
move TestAddSHA256 from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 14, 2019
run common_check_cipher_hash in libskycoin tests after refactor ref s…
ea25ad9 
…kycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 14, 2019
run tests against hardware wallet ref skycoin#34
95f7f43
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 14, 2019
makefile rule to run hardware wallet tests ref skycoin#34
308b148
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 14, 2019
fix in test-hw-crypto makefile rule ref skycoin#34
ed4c63a
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
Merge remote-tracking branch 'upstream/v0.25dev' into stdevAlDen_t34_…
810c8e5 
…hardware-wallet_tests

Conflicts:
	lib/cgo/tests/check_cipher.hash.c
	lib/cgo/tests/test_main.c
	lib/cgo/tests/testutils/libsky_assert.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
disable build matrix
907ee1a 
this commit should be reverted
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
refactor
bc3c949 
move TestAddressString from lib/cgo/tests/check_cipher.address.c to lib/cgo/tests/check_cipher.address.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
refactor
a16a448 
move registerMemCleanup from lib/cgo/tests/testutils/libsky_testutil.c to lib/cgo/tests/testutils/common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
refactor
e6596ab 
move TestAddressBulk from lib/cgo/tests/check_cipher.address.c to lib/cgo/tests/check_cipher.address.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
refactor
c308812 
move TestAddressNull from lib/cgo/tests/check_cipher.address.c to lib/cgo/tests/check_cipher.address.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
refactor
1ff07f2 
move copyGoSlice_toGoSlice from lib/cgo/tests/testutils/libsky_testutil.c to lib/cgo/tests/testutils/common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
refactor
9a90451 
move TestAddressFromBytes from lib/cgo/tests/check_cipher.address.c to lib/cgo/tests/check_cipher.address.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
refactor
66fd014 
move TestDecodeBase58Address from lib/cgo/tests/check_cipher.address.c to lib/cgo/tests/check_cipher.address.common.c
finally removed lib/cgo/tests/check_cipher.address.c as all address related test can be run against hardware wallet
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
refactor
1e8eedf 
moce TestHashRipemd160 from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
refactor
ffcec79 
move TestSHA256KnownValue from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 15, 2019
refactor
b0ae131 
move TestSumSHA256 from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 16, 2019
refactor
e3bef74 
move TestSHA256Hex from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 16, 2019
refactor
00a0099 
move TestSHA256Set from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 16, 2019
refactor
0408866 
move TestSHA256FromHex from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 16, 2019
refactor
9038eeb 
move TestSHA256Null from lib/cgo/tests/check_cipher.hash.c to lib/cgo/tests/check_cipher.hash.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 17, 2019
recator
6dc0acc 
move TestNewPubKey from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 17, 2019
refactor
f1f8671 
move TestPubKeyFromHex from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 17, 2019
refactor
40f0c59 
move TestPubKeyHex from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 17, 2019
refactor
f08c9b5 
move TestPubKeyVerify from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 17, 2019
refactor
50eb911 
move TestPubKeyVerifyNil from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 17, 2019
refactor
80c1c02 
move TestPubKeyVerifyDefault1 from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 17, 2019
refactor
df99fa2 
move TestPubKeyToAddress2 from lib/cgo/tests/check_cipher.crypto.c to lib/cgo/tests/check_cipher.crypto.common.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 23, 2019
Merge remote-tracking branch 'upstream/v0.25dev' into stdevAlDen_t34_…
757c3de 
…hardware-wallet_tests ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 23, 2019
add dependencies to test-hw-crypto rule ref skycoin#34
6fc9e33
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 23, 2019
run hw test with valgind ref skycoin#34
8778c36
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 23, 2019
disable mem clean up ref skycoin#34
54a5ae5
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 23, 2019
disable mem clean up ref skycoin#34
0b3e3f2
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 23, 2019
enable cleanupMem ref skycoin#34
f93a34c
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 23, 2019
Revert "fix bugs in tests suits ref skycoin#34"
0cb4f33 
This reverts commit 3d20e38.

ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 24, 2019
rebuild check library only if required ref skycoin#34
fe3a69a
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 24, 2019
fix bug ref skycoin#34
d2135b8
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 26, 2019
Merge remote-tracking branch 'simelo/v0.25dev' into stdevAlDen_t34_ha…
43a22e5 
…rdware-wallet_tests

Conflicts:
	Makefile
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 26, 2019
Merge remote-tracking branch 'simelo/v0.25dev' into stdevAlDen_t34_ha…
dab1157 
…rdware-wallet_tests

Conflicts:
	Makefile
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 26, 2019
move test-hw-crypto to hardware wallet repo ref skycoin#34
8c0307d
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 27, 2019
install check on linux if it is not build yet ref skycoin#34
3e6f1f7
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 27, 2019
fix bugs and/or warnings ref skycoin#34
af75a4b
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 29, 2019
fix memory buffer handling in TestPubKeyHex ref skycoin#34
b5bf315
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue May 29, 2019
fix test assertion in TestPubKeyHex ref skycoin#34
5a7bd53
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Jun 6, 2019
fix in TestAddressString ref skycoin#34
8af339a
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Jun 6, 2019
Fix in TestAddressBulk, initialize string memory in the test ref skyc…
cbcc513 
…oin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Jun 17, 2019
Fix buffer size in TestDecodeBase58Address ref skycoin#34
e2a5b2d
@stdevAlDen stdevAlDen mentioned this issue Jun 19, 2019
Open
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Aug 19, 2019
Merge remote-tracking branch 'upstream/develop' into stdevAlDen_t34_h…
f91833c 
…ardware-wallet_tests

Conflicts:
	lib/cgo/tests/check_cipher.address.common.c
	lib/cgo/tests/check_cipher.crypto.c
	lib/cgo/tests/check_cipher.hash.c
	lib/cgo/tests/testutils/libsky_assert.c
	lib/cgo/tests/testutils/libsky_testutil.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Aug 21, 2019
Merge branch 'stdevHan_t105_update_submodule_0.27.0' into stdevAlDen_…
8241bd4 
…t34_hardware-wallet_tests

Conflicts:
	lib/cgo/tests/check_cipher.crypto.c
	lib/cgo/tests/testutils/libsky_assert.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Aug 26, 2019
remove some test from hw
bdce11a 
 - TestAddressRoundtrip
 - TestAddressString
 - TestAddressBulk
 - TestDecodeBase58Address
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Aug 26, 2019
keep tests unchanged from 0.27 ref skycoin#34
175d7fa
@stdevAlDen stdevAlDen mentioned this issue Aug 26, 2019
Merged
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Aug 26, 2019
Merge remote-tracking branch 'simelo/stdevHan_t105_update_submodule_0…
b432115 
….27.0' into stdevAlDen_t34_hardware-wallet_tests

Conflicts:
	lib/cgo/tests/check_cipher.address.c
	lib/cgo/tests/testutils/libsky_assert.c
	lib/cgo/tests/testutils/libsky_testutil.c
ref skycoin#34
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Aug 26, 2019
refactor libsky_assert in two files ref skycoin#34
524c394
stdevAlDen pushed a commit to simelo/libskycoin.orig that referenced this issue Aug 26, 2019
remove TestPubKeyToAddress2 from the hw suit ref skycoin#34
b2f7e3c
This was referenced Oct 31, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP]hardware wallet tests ref #34 simelo/libskycoin.orig
1 participant
@stdevAlDen