add dmsghttp feature #131
Merged
add dmsghttp feature #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ersonp
reviewed
Nov 19, 2021
ersonp
reviewed
Nov 19, 2021
|
As this PR has been merged already and there are a few changes regarding the |
ersonp
reviewed
Nov 19, 2021
jdknives
reviewed
Nov 30, 2021
build.conf
Outdated
| @@ -29,6 +29,8 @@ SKYWIRE_VERSION=v0.5.0 | |||
|
|
|||
| SKYWIRE_ARM64_DOWNLOAD_URL="https://github.com/skycoin/skywire/releases/download/$SKYWIRE_VERSION/skywire-$SKYWIRE_VERSION-linux-arm64.tar.gz" | |||
| SKYWIRE_ARM_DOWNLOAD_URL="https://github.com/skycoin/skywire/releases/download/$SKYWIRE_VERSION/skywire-$SKYWIRE_VERSION-linux-arm.tar.gz" | |||
|
|
|||
| DMSGHTTP_CONFIG_URL="https://raw.githubusercontent.com/skycoin/skywire/master/dmsghttp-config.json" | |||
There was a problem hiding this comment.
This will fail for the time being, since we dont have that on master yet. Please change it to develop and make a ticket to swap it out once we make the new release.
There was a problem hiding this comment.
Done. Its issue is #133.
pkg/prepconf/prepare.go
Outdated
|
|
||
| if bp.DMSGHTTP == "dmsghttp" { | ||
| var dmsghttpData visorconfig.DmsgHTTPServers | ||
| dmsghttpFile, err := os.Open("/etc/dmsghttp-config.json") |
There was a problem hiding this comment.
Can we just use os.Readfile here?
There was a problem hiding this comment.
You're right. Handled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes skywire-services #423
Changes:
skyimagermake build-skybian-imgHow to test:
git clone [email protected]:mrpalide/skybian.git --branch feature/dsmghttpclone skywire@develop branch bygit clone [email protected]:mrpalide/skywire.git --branch developeditgo.modand uncommentreplace github.com/skycoin/skywire => ../skywiremake depchangeDMSGHTTP_CONFIG_URLon build.conf file tohttps://raw.githubusercontent.com/skycoin/skywire/develop/localServers.jsonmake build-skybian-img BOARD=rpi64 ARCH=arm64base on your board.make run-skyimager-guiand checkUse dmsgHTTP./etc/skywire-config.jsonto see new dmsghttp URLs services.Does this change need to mentioned in CHANGELOG.md?
Yes