Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to delete entries in transport discovery. #10

Closed
3 tasks
evanlinjin opened this issue Sep 30, 2019 · 1 comment
Closed
3 tasks

Add ability to delete entries in transport discovery. #10

evanlinjin opened this issue Sep 30, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@evanlinjin
Copy link
Contributor

Feature description

Currently, one can only update statuses of entries in transport discovery and cannot actually delete entries.

This causes issues when restarting transports. When we remove transports from visor, we only remove them locally. On visor startup, it polls transport discovery to determine saved transports. Hence, locally deleted transports are revived.

Implementation Details:

  • A transport between nodes A and B can only be deleted by A or B.

Tasks:

  • Add endpoint to transport discovery to delete transport.
  • Update transport discovery client.
  • Update (transport.Manager).DeleteTransport to call transport discovery's delete transport endpoint.
@evanlinjin evanlinjin added enhancement New feature or request milestone2 labels Sep 30, 2019
@jdknives jdknives changed the title [M2] [FEATURE] Add ability to delete entries in transport discovery. Add ability to delete entries in transport discovery. Oct 4, 2019
@jdknives
Copy link
Member

jdknives commented Nov 4, 2019

We should check, whether fixing this also fixes #30 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants