Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent erroneous hypervisor configuration #1046

Closed
0pcom opened this issue Jan 9, 2022 · 1 comment
Closed

prevent erroneous hypervisor configuration #1046

0pcom opened this issue Jan 9, 2022 · 1 comment

Comments

@0pcom
Copy link
Collaborator

0pcom commented Jan 9, 2022

When the config is generated like this:

skywire-cli config gen --hypervisor-pks <visor-pk> -ro skywire-config.json

If the visor pk in question is the public key contained already in skywire-config.json then the above command should produce the same result as the following

skywire-cli config gen -iro skywire-config.json

That is, trying to set a visor to use it's own public key as hypervisor should generate the same configuration as intentionally generating the config with hypervisor enabled.

Currently this is not the behavior

need to default to producing a working config as much as possible. This is likely what someone intended to do if they did the first command.

This also represents an edge-case for auto configuration, when it might happen coincidentally or by happenstance. So it is preferable for this to be addressed.

@mrpalide
Copy link
Contributor

mrpalide commented Jan 11, 2022

If I understood correctly, you want to keep hypervisors PKs list during generate new config file from last config, right?
If the answer is yes, this is available by -x flag, so just use skywire-cli config gen -irxo skywire-config.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants