Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows ui "reboot-visor" handling #1098

Closed
4rchim3d3s opened this issue Feb 13, 2022 · 3 comments
Closed

windows ui "reboot-visor" handling #1098

4rchim3d3s opened this issue Feb 13, 2022 · 3 comments
Labels
bug Something isn't working frontend

Comments

@4rchim3d3s
Copy link
Contributor

Describe the bug
When using skywire app on windows the following error comes up when trying to reboot the visor.

Environment information:

  • OS: Windows, v0.6.0-rc2

Steps to Reproduce
Steps to reproduce the behavior:

  1. Go to Menu
  2. Click on "reboot visor"

Actual behavior
image

Expected behavior
either restart the application or return a message like : "This function doesn't work on windows"

Additional context
Add any other context about the problem here.

Possible implementation
Hints to fix the bug.

@4rchim3d3s 4rchim3d3s added the bug Something isn't working label Feb 13, 2022
@0pcom
Copy link
Collaborator

0pcom commented Feb 13, 2022

I expect that most of the buttons to manipulates the visor process from the hypervisor UI is only going to work on linux.

In the second place i'm not sure how its being stopped from the UI on linux or if it works with the systemd services or robustly depending on how the process was started.

I would like at least more documentation of the hypervisor.

@4rchim3d3s when you see something like this, i also suggest checking the skywire-cli to see if we have a way to do it from cli for at least the local visor.

Because we do have some feature parity issues currently between visor and cli and that would be something to take into consideration along with the underlying issue.

@jdknives
Copy link
Member

@4rchim3d3s thanks for the issue. Will handle that in the next release.

@mrpalide
Copy link
Contributor

mrpalide commented May 6, 2022

In addition to the reboot button, the update button should not be available in Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

No branches or pull requests

4 participants