Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visor should not fail on path or minor version mismatch #1154

Closed
jdknives opened this issue Apr 15, 2022 · 0 comments
Closed

Visor should not fail on path or minor version mismatch #1154

jdknives opened this issue Apr 15, 2022 · 0 comments
Assignees
@jdknives
Labels
bug Something isn't working

Comments

@jdknives
Copy link
Member

Describe the bug

Currently the visor fails if the config version is behind the visor version even if the mismatch is only a patch or minor version. This should be dropped in favor of only checking for major version mismatch. Patch and minor changes are not supposed to introduce any breaking changes so it is unnecessary and annoying during development to fail on mismatch.
@jdknives jdknives added bug Something isn't working v0.7.0 labels Apr 15, 2022
@0pcom 0pcom mentioned this issue Apr 19, 2022
Merged
@jdknives jdknives self-assigned this Apr 20, 2022
@ersonp ersonp closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdknives jdknives

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdknives @ersonp