Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior when changing Skysocks config #146

Closed
jdknives opened this issue Jan 31, 2020 · 1 comment
Closed

Inconsistent behavior when changing Skysocks config #146

jdknives opened this issue Jan 31, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@jdknives
Copy link
Member

Initially described here by @Darkren : #123

Changing PK of skysocks-client which is STOPPED at this point. Logs:

Logs seem ok except for the fact that this request immediately starts the app even if it was closed. not sure if this is intended. but I get the following response from the API:

{
    "error": "stop app skysocks-client: unknown app"
}

UPD: it outputs Restarting app skysocks-client but that doesn't really happen, at least not in my case

Logging should be consistent and changing the value of config for Skysocks should not automatically restart the app.

@jdknives jdknives added the bug Something isn't working label Jan 31, 2020
@Darkren Darkren self-assigned this Feb 3, 2020
@jdknives
Copy link
Member Author

jdknives commented Feb 7, 2020

Closed by #149

@jdknives jdknives closed this as completed Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants