Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypervisor should re-establish transports after restart #155

Closed
jdknives opened this issue Feb 11, 2020 · 1 comment · Fixed by #166
Closed

Hypervisor should re-establish transports after restart #155

jdknives opened this issue Feb 11, 2020 · 1 comment · Fixed by #166
Assignees
Labels
enhancement New feature or request

Comments

@jdknives
Copy link
Member

Feature description

After shutting down and restarting the hypervisor, it should attempt to re-establish dmsg streams to the visors that have previously been connected to it.

Is your feature request related to a problem? Please describe.
When restarting a hypervisor, it does not establish dmsg streams to the visors previously connected, so a user would have to manually re-establish the connections, which comes with its own problems.

Describe the solution you'd like
The hypervisor could store the PubKeys fo the visors connected. After a restart, it should try to establish a new dmsg stream to them again once.

@jdknives jdknives added the enhancement New feature or request label Feb 11, 2020
@jdknives
Copy link
Member Author

jdknives commented Feb 13, 2020

Also, when the dmsg.Server crashes and comes back up, the session is re-established successfully on both sides (visor and hypervisor) but the stream between visor and hypervisor is not re-established and therefore no commands can be called from the hypervisor. This will need to be fixed. A restart fixes that, but the restart endpoint cannot be called without a connection, assuming we do not have access to node itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants