Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey missing on rare occasions #1570

Closed
0pcom opened this issue May 22, 2023 · 1 comment
Closed

Survey missing on rare occasions #1570

0pcom opened this issue May 22, 2023 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@0pcom
Copy link
Collaborator

0pcom commented May 22, 2023

a situation has recently come to my attention where visors may have the reward address set, but the survey is not there, for whatever reason.

The exact cause is pending investigation, however from a system design standpoint, it's clear that while using a static file is faster to collect the surveys, the nature of the survey being served over dmsghttp by the log server is dependent upon and may be disrupted by unforseen events and forces.

I suggest as a solution to this, an endpoint for the dmsghttp log server, /node-info which will generate the survey and serve it, regardless of the reward address having been set or not, and only to the whitelisted keys which are granted access to the survey.

While this will certainly be slower to respond, it's necessary to have this as a backup means of collecting the survey in case of issues with the file server, for purposes of reward calculation and distribution.

@0pcom 0pcom added the bug Something isn't working label May 22, 2023
@jdknives jdknives added this to the v1.3.11 milestone Jun 2, 2023
@0pcom
Copy link
Collaborator Author

0pcom commented Jun 11, 2023

workaround implemented in #1579

@0pcom 0pcom closed this as completed Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants