Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config migration on binaries update #168

Closed
nkryuchkov opened this issue Feb 27, 2020 · 1 comment · Fixed by #246
Closed

Config migration on binaries update #168

nkryuchkov opened this issue Feb 27, 2020 · 1 comment · Fixed by #246
Assignees
@nkryuchkov
Labels
enhancement New feature or request

Comments

@nkryuchkov
Copy link
Contributor

Feature description

We may need to deal with updating scenarios, where new config values are required for visor to run. In that case we will need to update the config file before restart of the visor after an update.

Originally posted by @jdknives in #129 (comment)

#153 implements support for updating skywire-visor, skywire-cli and app binaries. However, the scenario with new config values was not implemented.
@nkryuchkov nkryuchkov self-assigned this Feb 27, 2020
@nkryuchkov nkryuchkov mentioned this issue Feb 27, 2020
Closed
3 tasks
@nkryuchkov nkryuchkov added the enhancement New feature or request label Feb 27, 2020
@nkryuchkov nkryuchkov removed their assignment Mar 5, 2020
@nkryuchkov nkryuchkov self-assigned this Mar 13, 2020
@nkryuchkov nkryuchkov mentioned this issue Mar 24, 2020
Merged
@nkryuchkov nkryuchkov linked a pull request Mar 24, 2020 that will close this issue
Use default values if required visor config fields are empty #246
Merged
@jdknives
Copy link
Member

Fixed by #246 246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkryuchkov nkryuchkov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use default values if required visor config fields are empty nkryuchkov/skywire
2 participants
@nkryuchkov @jdknives