Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to appserver. #338

Closed
evanlinjin opened this issue Apr 21, 2020 · 0 comments
Closed

Improvements to appserver. #338

evanlinjin opened this issue Apr 21, 2020 · 0 comments
Assignees
@evanlinjin
Labels
enhancement New feature or request

Comments

@evanlinjin
Copy link
Contributor

evanlinjin commented Apr 21, 2020 •
edited
Loading

Feature description

Currently appserver.RPCGateway is registered in the rpc.Server for every app connection. This, although a quick solution at the time, results in the follow problems:

  1. If apps disconnect/reconnect this will lead to memory leaks as we cannot unregister from an rpc.Server.
  2. It becomes difficult to track number of multiplexed connections to the app and whether the app is connected with the same structure.

Additionally, the responsibilities of the ProcManager structure can be expanded, removing the need for visor.Visor to include app management logic.

Describe the solution you'd like

  • Only register one instance of appserver.RPCGateway
  • For each RPC method, include field for inputting the App Secret.
@evanlinjin evanlinjin added the enhancement New feature or request label Apr 21, 2020
@evanlinjin evanlinjin self-assigned this Apr 21, 2020
@evanlinjin evanlinjin mentioned this issue May 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evanlinjin evanlinjin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evanlinjin