Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up sorting imports correctly #361

Closed
nkryuchkov opened this issue May 15, 2020 · 4 comments
Closed

Set up sorting imports correctly #361

nkryuchkov opened this issue May 15, 2020 · 4 comments
Assignees
@nkryuchkov
Labels
enhancement New feature or request

Comments

@nkryuchkov
Copy link
Contributor

Feature description

We run goimports in make format which sorts imports. However, it does not group them correctly. The right order is:

  1. Standard library imports
  2. 3rd party libraries
  3. Current project imports.

We need to find a way to sort them in the correct order automatically.
@nkryuchkov nkryuchkov added the enhancement New feature or request label May 15, 2020
@nkryuchkov nkryuchkov mentioned this issue May 15, 2020
Merged
@jdknives
Copy link
Member

jdknives commented May 21, 2020 •
edited
Loading

https://github.com/incu6us/goimports-reviser is not usable.

@jdknives
Copy link
Member

jdknives commented Jun 1, 2020

@nkryuchkov maybe it would make sense to raise an issue with goimports-reviser.

@nkryuchkov nkryuchkov mentioned this issue Jun 1, 2020
Merged
@nkryuchkov
Copy link
Contributor Author

@jdknives It looks like https://github.com/incu6us/goimports-reviser works great now. Let's test it.

@nkryuchkov nkryuchkov self-assigned this Jun 1, 2020
@nkryuchkov
Copy link
Contributor Author

WIll be closed by all referenced PRs.

@jdknives jdknives closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkryuchkov nkryuchkov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkryuchkov @jdknives