Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new flags to hypervisor app management #609

Closed
jdknives opened this issue Nov 19, 2020 · 2 comments
Closed

Add new flags to hypervisor app management #609

jdknives opened this issue Nov 19, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request frontend

Comments

@jdknives
Copy link
Member

Feature description

Two new flags will be added to the VPN with the next release.

  • killswitch
  • secure

Both accept boolean values. They need to be changeable via the app management interface in the UI.

Reference PRs

@jdknives jdknives added enhancement New feature or request frontend labels Nov 19, 2020
@Senyoret1
Copy link
Contributor

I added the options to the UI, but for saving the changes, I need to send the new setting to the PUT /visors/{pk}/apps/{app} API endpoint, which is how the manager currently saves the changes for all app settings. The problem is that the endpoint currently does not accept the killswitch and secure options. After making the endpoint able to receive those settings, I think it will be possible to make the final changes.

@jdknives
Copy link
Member Author

@Senyoret1 just merged #618 so you should be able to go ahead.

@jdknives jdknives closed this as completed Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

No branches or pull requests

2 participants