Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement backoff for transport reconnection #68

Closed
2 tasks done
jdknives opened this issue Nov 13, 2019 · 0 comments · Fixed by #166
Closed
2 tasks done

Implement backoff for transport reconnection #68

jdknives opened this issue Nov 13, 2019 · 0 comments · Fixed by #166
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jdknives
Copy link
Member

jdknives commented Nov 13, 2019

Feature description

Currently, when one edge of a transport goes down, the other edge will try to re-establish the transport every three seconds. We should implement a backoff for re-establishing the transport. @evanlinjin suggested using the retry logic in /internal/netutil . Also, we need to improve logging, so that these messages do not clutter stdout:

[2019-11-13T10:59:10+08:00] WARN [tp:03c775]: failed to redial underlying connection: dial tcp 192.168.0.107:7777: connect: connection refused

  • improve logging
  • implement retrial backoff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
4 participants