Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Travis and Makefile #717

Closed
jdknives opened this issue Mar 12, 2021 · 0 comments
Closed

Cleanup Travis and Makefile #717

jdknives opened this issue Mar 12, 2021 · 0 comments

Comments

@jdknives
Copy link
Member

Request

Travis:

There are a few actions in the .travis.yml that may not be necessary. We should verify, that all the actions performed in Travis file are actually necessary. Things such as vendor cleanup, the comment that links to a closed golangci-lint and the make test-no-ci could potentially be redundant/useless.

The makefile similarly contains targets that I am not sure we are actually using anywhere. Some of them (although this needs to be verified on a case by case basis):

  • deploy static
  • rerun

There may be more of these. Also, if we are using the docker targets, we should maybe move them to a separate Makefile within the docker directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant