You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are multiple levels of extra that seems to have been added over time. Visor has summary and extra summary, and hypervisor has his own extra summary, plus response wrappers around visor summaries:
hypervisor provides:
visor.Summary (via getVisor()), wraps in summaryResp
visor.ExtraSummary (via getVisorSummary()), wraps in extraSummaryResp
its own extra summary (extra-extra now?) (via getVisorsExtraSummary()), extraSummaryWithDmsgResp
There are some overlaps between those structures but not always, e.g. visor.ExtraSummary Dmsg is different from Dmsg in extraSummaryWithDmsgResp. So we cannot simply embed one into other.
I would propose:
Remove Dmsg from visor.ExtraSummary. This field is not populated by visor api, so there is no reason to have it there.
Investigate why do we need dmsg stats for all visors in getVisorSummary, since we are asking for stats of a single visor.
In case we don't need that data, extraSummaryWithDmsgResp and extraSummaryResp become equivalent and the former
can be removed
Factor out TCPAddr and Online fields into its own struct, maybe smth like NetworkStats?
Rename summary to overview like @jdknives suggested, and extra summary to just summary
The text was updated successfully, but these errors were encountered:
Original comment from @i-hate-nicknames :
There are multiple levels of extra that seems to have been added over time. Visor has summary and extra summary, and hypervisor has his own extra summary, plus response wrappers around visor summaries:
hypervisor provides:
visor.Summary
(viagetVisor()
), wraps insummaryResp
visor.ExtraSummary
(viagetVisorSummary()
), wraps inextraSummaryResp
getVisorsExtraSummary()
),extraSummaryWithDmsgResp
There are some overlaps between those structures but not always, e.g. visor.ExtraSummary Dmsg is different from Dmsg in extraSummaryWithDmsgResp. So we cannot simply embed one into other.
I would propose:
In case we don't need that data, extraSummaryWithDmsgResp and extraSummaryResp become equivalent and the former
can be removed
The text was updated successfully, but these errors were encountered: