You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Building the sources from release produces error messages although the build succeeds: fatal: not a git repository (or any of the parent directories): .git
Environment information:
OS: Linux 5.11.0-27-generic x86_64
Steps to Reproduce
Steps to reproduce the behavior:
The context of it's occurrence is in any build which uses the source archive for a particular versioned release rather than just the latest commits on whichever branch. It's a smaller download to use the source archive, and the build is more consistent.
My solution above is to manually version to the tag version in the build, with the necessary lines borrowed (and modified) from the Makefile.
The general solution would be to specifically alter how the versions are generated in the release archive- in order to not have to use git for the versioning. I don't think it's bad to use git for versioning, nor do i think it should stop being used; but it remains unclear how to sufficiently reduce the size of the .git folder to the point it would not needlessly bloat the archive for the simple purpose of supplying the version.
ppcamp
added a commit
to ppcamp/skywire
that referenced
this issue
Nov 13, 2021
It solves the error raised when building the application when you don't clone the repository from
github. This change also allows the user to set manually the VERSION and the COMMIT using
environment variables
fixskycoin#875
Describe the bug
Building the sources from release produces error messages although the build succeeds:
fatal: not a git repository (or any of the parent directories): .git
Environment information:
Steps to Reproduce
Steps to reproduce the behavior:
make build
fatal: not a git repository (or any of the parent directories): .git
Actual behavior
Building the source should not produce any error messages even if there is no initialized
.git
repository.Expected behavior
make build
of sources from any release should not produce the error message.Additional context
The
Makefile
commands in:appear to be causing this bug.
The text was updated successfully, but these errors were encountered: