Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two dataraces on visor shutdown #890

Closed
ersonp opened this issue Sep 23, 2021 · 1 comment
Closed

Two dataraces on visor shutdown #890

ersonp opened this issue Sep 23, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@ersonp
Copy link
Contributor

ersonp commented Sep 23, 2021

Describe the bug
On closing the visor with Ctrl+C 2 data races are seen.

Environment information:

  • OS: Linux
  • Platform: Linux 5.11.0-34-generic x86_64

Steps to Reproduce
Steps to reproduce the behavior:

  1. Run go build -race -o ./skywire-visor ./cmd/skywire-visor
  2. Run ./skywire-visor skywire-config.json
  3. Press Ctrl+C
  4. See error

Actual behavior
On closing the visor with Ctrl+C 2 data races are seen.
datarace.log

Expected behavior
Visor shutdown without any error.
@ersonp ersonp added the bug Something isn't working label Sep 23, 2021
@alexadhy
Copy link
Contributor

Can be reproduced in macOS as well

@ersonp ersonp mentioned this issue Sep 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdknives @ersonp @alexadhy