Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datarace while stopping vpn-server app #896

Closed
ersonp opened this issue Sep 27, 2021 · 2 comments
Closed

Datarace while stopping vpn-server app #896

ersonp opened this issue Sep 27, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@ersonp
Copy link
Contributor

ersonp commented Sep 27, 2021

Describe the bug
A datarace is seen when a vpn-server app is stopped.

Environment information:

  • OS: e.g. Linux
  • Platform: Linux 5.11.0-36-generic x86_64

Steps to Reproduce
Steps to reproduce the behavior:

  1. Run
$ go build -race -o ./apps/vpn-server ./cmd/apps/vpn-server
$ go build -race -o ./skywire-visor ./cmd/skywire-visor
  1. Run './skywire-visor skywire-config.json'
  2. Start the vpn-server from hypervisor UI and then stop it
  3. See error

Actual behavior
datarace.log

Expected behavior
Stop vpn-server without datarace.
@ersonp ersonp added the bug Something isn't working label Sep 27, 2021
@alexadhy
Copy link
Contributor

#897 seems to have fixed this, can't reproduce it with latest develop.

@ersonp
Copy link
Contributor Author

ersonp commented Sep 29, 2021

Can't replicate the error anymore after #897 on Linux either. Closing this.

@ersonp ersonp closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ersonp @alexadhy