Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make /exec endpoint consistent with others #92

Closed
nkryuchkov opened this issue Dec 26, 2019 · 1 comment
Closed

Make /exec endpoint consistent with others #92

nkryuchkov opened this issue Dec 26, 2019 · 1 comment
Assignees
@nkryuchkov
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@nkryuchkov
Copy link
Contributor

While all endpoints for nodes management look like /nodes/{pk}/{action}, the endpoint for command execution looks like /exec/{pk}, which is not consistent with others and violates REST.

I think /nodes/{pk}/exec would look better.
@nkryuchkov nkryuchkov added bug Something isn't working good first issue Good for newcomers Milestone 3 labels Dec 26, 2019
@nkryuchkov nkryuchkov self-assigned this Jan 24, 2020
@nkryuchkov nkryuchkov mentioned this issue Jan 24, 2020
Merged
@jdknives
Copy link
Member

Fixed by #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkryuchkov nkryuchkov

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkryuchkov @jdknives