New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix visor uses default config with no arguments #1176

Merged

0pcom merged 2 commits into skycoin:develop from the-skycoin-project:fix-visor-default-config

May 9, 2022

Collaborator

0pcom commented May 3, 2022

Did you run make format && make check?
yes

visor uses skywire-config.json with no arguments by default

Changes:

visor should use the default config if present without needing to specify -c skywire-config.json

How to test this PR:

git clone --single-branch -b fix-visor-default-config https://github.com/the-skycoin-project/skywire
cd skywire
make build
./skywire-cli config gen -r
./skywire-visor


          visor uses skywire-config.json with no arguments by default

d86bce7

jdknives requested changes

View reviewed changes

Member

jdknives left a comment

Needs mention in changelog.


          Update CHANGELOG.md

44f9433

0pcom merged commit 9d9beb8 into skycoin:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet