Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Implemented backoff for transport reconnection #119

Closed
wants to merge 10 commits into from
Closed

WIP: Implemented backoff for transport reconnection #119

wants to merge 10 commits into from

Conversation

Kifen
Copy link
Contributor

@Kifen Kifen commented Jan 15, 2020 •
edited
Loading

Fixes #68

Changes:

  • updated transport connection redial with a backoff implementation

How to test this PR:
Establish a connection between two visors, then shut down one visor

@Kifen Kifen requested review from nkryuchkov and jdknives January 15, 2020 15:27
@Kifen Kifen changed the title Implemented backoff for transport reconnection WIP: Implemented backoff for transport reconnection Jan 15, 2020
nkryuchkov
nkryuchkov reviewed Jan 15, 2020
View reviewed changes
pkg/transport/managed_transport.go Outdated Show resolved Hide resolved
pkg/transport/managed_transport.go Outdated Show resolved Hide resolved
pkg/transport/managed_transport.go Outdated Show resolved Hide resolved
pkg/transport/managed_transport.go Outdated Show resolved Hide resolved
pkg/transport/managed_transport.go Outdated Show resolved Hide resolved
evanlinjin
evanlinjin suggested changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logTicker.C was to ensure actions were logged in database. We should really keep this.
The exponential backoff should only trigger when we have disconnected from the underlying connection.

pkg/transport/managed_transport.go Outdated Show resolved Hide resolved
pkg/transport/managed_transport.go Outdated Show resolved Hide resolved
nkryuchkov
nkryuchkov reviewed Jan 16, 2020
View reviewed changes
cmd/skywire-cli/commands/node/gen-config.go Show resolved Hide resolved
pkg/transport/managed_transport.go Outdated Show resolved Hide resolved
pkg/visor/visor.go Outdated Show resolved Hide resolved
@jdknives
Copy link
Member

jdknives commented Feb 3, 2020

Made obsolete by #148

@jdknives jdknives closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkryuchkov nkryuchkov nkryuchkov left review comments

@evanlinjin evanlinjin evanlinjin requested changes

@jdknives jdknives Awaiting requested review from jdknives

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement backoff for transport reconnection
4 participants
@Kifen @jdknives @evanlinjin @nkryuchkov