Make the session cookie work with the terminal #258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you run
make format && make check
?Yes
Fixes #248
Changes:
Path
param, set in the hypervisor configuration file, is added to the session cookie. This makes the web browser start sending the session cookie to the terminal window while using the default config, as previously web browsers were sending the cookie only to the/api
paths (default browser behavior if thePath
param is not set). This makes the terminal work with https connections while auth is activated.How to test this PR:
Open the full terminal using the manager while auth and tls are active. See note below.