Feature/retain keys #359
Merged
Feature/retain keys #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkryuchkov
suggested changes
May 13, 2020
There was a problem hiding this comment.
I've checked the feature, it worked fine. Good job! I have some requests regarding the changes in the PR:
-
Could you please change the target branch from
mastertodevelop? -
The PR description might look clearer if it was adjusted according to the template here: https://github.com/SkycoinProject/skywire-mainnet/blob/master/.github/pull_request_template.md
-
Please run
make format.
| } | ||
|
|
||
| conf.PK = oldConf.PK | ||
| conf.SK=oldConf.SK |
There was a problem hiding this comment.
Could you please add spaces around =?
nkryuchkov
approved these changes
May 13, 2020
jdknives
approved these changes
May 13, 2020
jdknives
added a commit
that referenced
this pull request
Oct 19, 2020
Feature/retain keys Former-commit-id: 442b35e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added retain keys flag which is only set when -r is also set.