Fix transport manager hangs and various improvements. #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Restructured (transport.Manager).SaveTransport to improve readability and ensure we always close the managed transport before calling mTp.wg.Wait(). In fact, we are now using mTp.Close() directly (which does both). * Visor's RPC client timeout is now optional. Setting a value of 0 duration will result in no timeout. * Disabled visor RPC client timeout for visor CLI.
Darkren
suggested changes
May 27, 2020
nkryuchkov
approved these changes
May 27, 2020
There was a problem hiding this comment.
Except for the @Darkren 's note, the code looks good to me. But not sure about the timeout. Great job!
* Replaced goto statement with for loop in transport.Manager
evanlinjin
force-pushed
the
fix/tpm-hangs-#375
branch
from
4db4c08 to
c84dbe7
Compare
jdknives
pushed a commit
that referenced
this pull request
Oct 19, 2020
Fix transport manager hangs and various improvements. Former-commit-id: 84fd905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375
Changes:
Additional Changes:
How to test this PR:
skywire-visor.skywire-cli.