Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointer dereference #886

Merged
merged 3 commits into from
Sep 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .appveyor.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
version: "{build}"

stack: node 10.16.3
stack: node 16.8.0

environment:
matrix:
Expand All @@ -11,9 +11,9 @@ environment:
- job_name: MacOS
appveyor_build_worker_image: macos
GOARCH: amd64
- job_name: Windows
appveyor_build_worker_image: Visual Studio 2019
GOARCH: amd64
# - job_name: Windows
# appveyor_build_worker_image: Visual Studio 2019
# GOARCH: amd64

# For release, by pushing tag
- job_name: linux-amd64
Expand Down
2 changes: 1 addition & 1 deletion pkg/setup/node.go
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ func ReserveRouteIDs(ctx context.Context, log logrus.FieldLogger, dialer network
}()

if err = idR.ReserveIDs(ctx); err != nil {
return nil, fmt.Errorf("failed to reserve route ids: %w", err)
return idR, fmt.Errorf("failed to reserve route ids: %w", err)
}
return idR, nil
}
Expand Down