web-api(fix): allow typed token overrides in supported methods (#1872)

slackapi · Aug 14, 2024 · 5fbb3bd · 5fbb3bd
1 parent 3a7d3b5
commit 5fbb3bd
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 3 deletions.
diff --git a/packages/web-api/src/types/request/admin/apps.ts b/packages/web-api/src/types/request/admin/apps.ts
@@ -59,7 +59,7 @@ export type AdminAppsApprovedListArguments = Partial<TeamOrEnterpriseID> & Token
 & Certified;
 
 // https://api.slack.com/methods/admin.apps.clearResolution
-export type AdminAppsClearResolutionArguments = AppID & TeamOrEnterpriseID;
+export type AdminAppsClearResolutionArguments = AppID & TeamOrEnterpriseID & TokenOverridable;
 
 // https://api.slack.com/methods/admin.apps.config.lookup
 export interface AdminAppsConfigLookupArguments extends TokenOverridable {
@@ -95,4 +95,4 @@ export type AdminAppsRestrictedListArguments = TeamOrEnterpriseID & Certified &
 & CursorPaginationEnabled;
 
 // https://api.slack.com/methods/admin.apps.uninstall
-export type AdminAppsUninstallArguments = AppID & TeamOrEnterpriseID;
+export type AdminAppsUninstallArguments = AppID & TeamOrEnterpriseID & TokenOverridable;
diff --git a/packages/web-api/src/types/request/apps.ts b/packages/web-api/src/types/request/apps.ts
@@ -34,4 +34,4 @@ export interface AppsManifestValidateArguments extends Partial<AppID>, TokenOver
 }
 
 // https://api.slack.com/methods/apps.uninstall
-export interface AppsUninstallArguments extends Pick<OAuthCredentials, 'client_id' | 'client_secret'> {}
+export interface AppsUninstallArguments extends Pick<OAuthCredentials, 'client_id' | 'client_secret'>, TokenOverridable {}
diff --git a/packages/web-api/test/types/methods/admin.apps.test-d.ts b/packages/web-api/test/types/methods/admin.apps.test-d.ts
@@ -91,6 +91,16 @@ expectAssignable<Parameters<typeof web.admin.apps.clearResolution>>([{
   team_id: 'T1234',
 }]);
 expectAssignable<Parameters<typeof web.admin.apps.clearResolution>>([{
+  token: 'xoxp-example',
+  app_id: 'A1234',
+  team_id: 'T1234',
+}]);
+expectAssignable<Parameters<typeof web.admin.apps.clearResolution>>([{
+  app_id: 'A1234',
+  enterprise_id: 'E1234',
+}]);
+expectAssignable<Parameters<typeof web.admin.apps.clearResolution>>([{
+  token: 'xoxp-example',
   app_id: 'A1234',
   enterprise_id: 'E1234',
 }]);
@@ -239,6 +249,16 @@ expectAssignable<Parameters<typeof web.admin.apps.uninstall>>([{
   team_id: 'T1234',
 }]);
 expectAssignable<Parameters<typeof web.admin.apps.uninstall>>([{
+  token: 'xoxp-example',
+  app_id: 'A1234',
+  team_id: 'T1234',
+}]);
+expectAssignable<Parameters<typeof web.admin.apps.uninstall>>([{
+  app_id: 'A1234',
+  enterprise_id: 'E1234',
+}]);
+expectAssignable<Parameters<typeof web.admin.apps.uninstall>>([{
+  token: 'xoxp-example',
   app_id: 'A1234',
   enterprise_id: 'E1234',
 }]);
diff --git a/packages/web-api/test/types/methods/apps.test-d.ts b/packages/web-api/test/types/methods/apps.test-d.ts
@@ -101,3 +101,8 @@ expectAssignable<Parameters<typeof web.apps.uninstall>>([{
   client_id: '1234.56',
   client_secret: 'ABC123',
 }]);
+expectAssignable<Parameters<typeof web.apps.uninstall>>([{
+  token: 'xoxb-example',
+  client_id: '1234.56',
+  client_secret: 'ABC123',
+}]);