Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebClient logLevel option doesn't affect logging to stdout #334

Closed
3 tasks done
aoberoi opened this issue Apr 9, 2017 · 0 comments · Fixed by #436
Closed
3 tasks done

WebClient logLevel option doesn't affect logging to stdout #334

aoberoi opened this issue Apr 9, 2017 · 0 comments · Fixed by #436
Labels
enhancement M-T: A feature request for new functionality
Milestone
v3.15.0

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Apr 9, 2017

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Description

logLevel is an option that's defined on both RtmClient and WebClient, but it seems the WebClient doesn't do anything when its set to a valid option (such as 'debug' or 'silly').

Reproducible in:

@slack/client version: 3.9.0
@aoberoi aoberoi added the feature label Apr 9, 2017
@aoberoi aoberoi added enhancement M-T: A feature request for new functionality and removed feature labels Oct 3, 2017
@aoberoi aoberoi changed the title WebClient doesn't utilize logLevel option WebClient logLevel option doesn't affect logging to stdout Oct 3, 2017
@aoberoi aoberoi added this to the v3.15.0 milestone Oct 26, 2017
@aoberoi aoberoi mentioned this issue Dec 20, 2017
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Milestone
v3.15.0
Development

Successfully merging a pull request may close this issue.

Logger refactor aoberoi/node-slack-sdk
1 participant
@aoberoi