Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of WebClient to perform oauth.access not allowed without an API token #404

Closed
3 tasks done
nogurenn opened this issue Oct 2, 2017 · 3 comments
Closed
3 tasks done
Labels
enhancement M-T: A feature request for new functionality good first issue

Comments

@nogurenn
Copy link

nogurenn commented Oct 2, 2017

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Description

This came up while I was developing an AWS Lambda function invoked by Slack OAuth's redirect_uri that will continue the OAuth dance. I thought it was counterintuitive that the WebClient doesn't allow tokenless invocation of oauth.access() (like a static/class-level method) and wondered if this can be seen as an enhancement.

@aoberoi aoberoi added enhancement M-T: A feature request for new functionality good first issue labels Oct 4, 2017
@aoberoi
Copy link
Contributor

aoberoi commented Oct 4, 2017

@nogurenn that seems like a reasonable enhancement request!

just FYI, you could instantiate a WebClient without a token and invoke the web.oauth.access() method. i know you are asking for a static method.

if we do implement this API, it seems like the most straightforward path would be instantiate a "temporary" instance of the WebClient and just invoke that method. otherwise, we would have to initialize a whole bunch of resources/state and that would duplicate the code in the constructor.

@nogurenn
Copy link
Author

nogurenn commented Oct 5, 2017

It feels more natural to invoke it "statically." If it works, it works! 💯

@aoberoi aoberoi added this to the v4.0.0 milestone Dec 22, 2017
@aoberoi aoberoi removed this from the v4.0.0 milestone Mar 8, 2018
@aoberoi
Copy link
Contributor

aoberoi commented Mar 10, 2018

closing since this seems to work in v3, and v4 is now out. issue #482 is relevant.

@aoberoi aoberoi closed this as completed Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality good first issue
Projects
None yet
Development

No branches or pull requests

2 participants