Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebClient should accept an optional token ? #491

Closed
4 of 9 tasks
bilby91 opened this issue Mar 12, 2018 · 2 comments
Closed
4 of 9 tasks

WebClient should accept an optional token ? #491

bilby91 opened this issue Mar 12, 2018 · 2 comments
Labels
duplicate An issue for the same purpose already exists, and a link is in the comments

Comments

@bilby91
Copy link

bilby91 commented Mar 12, 2018

Description

When using the WebClient for calling oauth methods a token is not required. WebClient token argument shouldn't be optional ?

Example: https://github.com/suttna/botbuilder-slack/blob/master/src/interactors/oauth_interactor.ts#L16

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

@aoberoi
Copy link
Contributor

aoberoi commented Mar 12, 2018

Thanks for reporting. We're aware of the issue and are tracking it in #482. I hope to have a fix available in the next couple days.

@aoberoi aoberoi added the duplicate An issue for the same purpose already exists, and a link is in the comments label Mar 12, 2018
@aoberoi aoberoi closed this as completed Mar 12, 2018
@bilby91
Copy link
Author

bilby91 commented Mar 12, 2018

@aoberoi Awesome, let me know if I can help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate An issue for the same purpose already exists, and a link is in the comments
Projects
None yet
Development

No branches or pull requests

2 participants