-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add author_subname
type
#1621
Add author_subname
type
#1621
Conversation
Thanks for the contribution! Before we can merge this, we need @mztnnrt to sign the Salesforce Inc. Contributor License Agreement. |
Hey @mztnnrt 👋🏻 Thanks a bunch for the pull request 🙇🏻 It's wonderful to hear that you've finding the project helpful and we always appreciate pull requests that continue to improve the project for everyone! I'll be honest, I didn't know the Regardless, for those in-the-know, the property is still supported by message attachments and displays correctly in Slack. It's quite slick! How do the other maintainer's feel about adding this type? It seems good to me. |
Hi @mwbrooks, Thanks your reply ! 🙏 Yes ! In fact, I also don't know how long Slack will support |
I also think this is a good addition 👍 We may want to add the field here too, but missing it there at this moment doesn't necessarily prevent us from adding the actually working thing to the SDKs. I can work on Python/Java SDKs later on. |
My updates on this: |
Hi @seratch 👋 Thanks for your adjustment about this P.S. I always read your article qiita.com about Slack and it's very useful, thanks. |
Hello! I would like to start by expressing my sincere appreciation for your consistent contributions to this project.
Thank you so much!
Summary
Add
author_subname
for message, the section indicated by the arrow.Other language API Client ex. slack-go/slack
https://github.com/slack-go/slack/blob/c4095cb17cf21c2b2b9c459d5512d14ca5143f64/attachments.go#L70-L71
Requirements (place an
x
in each[ ]
)