chore: tweak lint config to allow for eslint --fix to fix import order
#1827
Conversation
filmaj
added
semver:patch
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1827 +/- ##
==========================================
+ Coverage 81.81% 81.85% +0.04%
==========================================
Files 35 35
Lines 7763 7782 +19
Branches 317 317
==========================================
+ Hits 6351 6370 +19
Misses 1400 1400
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
| import stream from 'stream'; | ||
|
|
||
| import { assert } from 'chai'; | ||
| import sinon from 'sinon'; | ||
|
|
||
| import { shell } from './shell'; | ||
|
|
||
| import type { ShellProcess } from '../utils/types'; |
There was a problem hiding this comment.
😱 Big fan of splitting stdlib from dependencies from local from types if that's what this rule is requiring!
| @@ -1,4 +1,4 @@ | |||
| import { createLogger, format, transports, Logger } from 'winston'; | |||
| import { Logger, createLogger, format, transports } from 'winston'; | |||
There was a problem hiding this comment.
Uppercase alphabetization is a big winston 🏆
packages/web-api/src/methods.ts
Outdated
| // Request types | ||
| import type { |
There was a problem hiding this comment.
🗒️ Might be nice to also swap 🪓 the request and response comments for these moving types!
| LinkUnfurls, | ||
| MessageAttachment, | ||
| MessageMetadata, | ||
| } from '@slack/types'; |
There was a problem hiding this comment.
This ordering seems unexpected to me - I'd've thought @slack/types finds a place before ./* imports - but no blocker if this is what the linter likes 🙏
Also only noticed this in a few web-api files... Not sure why though!
There was a problem hiding this comment.
I'm also not sure why.... but I almost don't want to ask questions. Just tell me how to order the damn things and don't make me think!
filmaj
force-pushed
the
eslint-sort-imports
branch
from
ac6c902
to
8ec1793
Compare
Small maintainer QoL fix: tweaked the eslint config to use a combination of ESLint's stock
sort-importsrule andeslint-plugin-import'simport/orderrule to allow foreslint --fixto fix import ordering. This was driving me a bit crazy eyetwitch and I found this comment that showed off using the two rules in combo.Also ensured all the
lintnpm run scripts use the--fixrule across all monorepo packages.The only change worth reviewing is within
lint-configs/- all other file changes are simply style fixes.