-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web-api(fix): allow typed token overrides in supported methods #1872
web-api(fix): allow typed token overrides in supported methods #1872
Conversation
Fixes slackapi#1871 with a few other methods: - admins.apps.clearResolution - admin.apps.uninstall - apps.uninstall
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1872 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 34 34
Lines 7648 7648
Branches 374 374
=======================================
Hits 6872 6872
Misses 764 764
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To prevent a regression here, can we add a type test for this?
@filmaj always a good call! Added! 🧪 🔍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👨🍳 💋 much obliged 🙇
Summary
Fixes #1871 and allows token overrides with a few other methods to match the documented arguments:
Reviewers
Confirm this builds without errors in a TypeScript application:
Notes
uninstall
methods didn't includetoken
but I believe it's alright to include as an argument.Requirements