Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove reference files in source #1896

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

lukegalbraithrussell
Copy link
Contributor

@lukegalbraithrussell lukegalbraithrussell commented Aug 19, 2024

Summary

Checking in the autogenerated reference files to github is just a lot. They autogenerate on build so they don't need to be in source. This removes them from the repo and makes sure they stay removed

Failing tests will pass once #1895 is merged

Requirements (place an x in each [ ])

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (deb51ea) to head (7959f01).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1896   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          34       34           
  Lines        7648     7648           
  Branches      374      374           
=======================================
  Hits         6872     6872           
  Misses        764      764           
  Partials       12       12           
Flag Coverage Δ
cli-hooks 94.94% <ø> (ø)
cli-test 94.77% <ø> (ø)
oauth 76.53% <ø> (ø)
socket-mode 59.59% <ø> (ø)
web-api 96.57% <ø> (ø)
webhook 95.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lukegalbraithrussell lukegalbraithrussell marked this pull request as ready for review August 20, 2024 00:13
@lukegalbraithrussell lukegalbraithrussell added the docs M-T: Documentation work only label Aug 20, 2024
@filmaj
Copy link
Contributor

filmaj commented Aug 20, 2024

The changes look good to me but I did notice the documentation GitHub Action had some warnings and errors: https://github.com/slackapi/node-slack-sdk/actions/runs/10470951573/job/28997183768?pr=1896

Should we look into those while we're here? I can assist with this as well

@lukegalbraithrussell
Copy link
Contributor Author

The error has been appearing on previous ones too -- https://github.com/slackapi/node-slack-sdk/actions/runs/10325270022/job/28586508803. I'm going to merge this since its status quo and then look into it

@lukegalbraithrussell lukegalbraithrussell merged commit 83a52fd into main Aug 21, 2024
32 checks passed
@lukegalbraithrussell lukegalbraithrussell deleted the docs-reference-info branch August 21, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants