-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove eslint, use biome instead #2006
Conversation
3182d5a
to
d17be1e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2006 +/- ##
==========================================
+ Coverage 90.26% 91.61% +1.34%
==========================================
Files 34 37 +3
Lines 7666 9924 +2258
Branches 381 633 +252
==========================================
+ Hits 6920 9092 +2172
- Misses 734 820 +86
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Too many changes to review but they should be safe. Regarding the changes under packages/web-api/src/types/response/
, it's fine! but we may want to add the additional step that applies biome after generating in the script.
Sounds @seratch , I will follow up with another PR for that shortly, and can test it out by running it in the PR, too. |
Many lines of code, little actual change. Perhaps the only thing worth taking a look at is the
biome.json
file that describes the lint and formatting rules.Changes