Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize handling of arguments with binary value types #519

Merged
merged 4 commits into from
Mar 23, 2018
Merged

Generalize handling of arguments with binary value types #519

merged 4 commits into from
Mar 23, 2018

Commits on Mar 17, 2018

  1. Enable WebClient to send binary data

    @clavin
    clavin committed Mar 17, 2018
    Configuration menu
    Copy the full SHA
    ad2c4d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2018

  1. an alternative that doesn't involve creating a WebClientBinaryData cl… 

    …ass, fixes slackapi#452
    @aoberoi
    aoberoi committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    aefe461 View commit details
    Browse the repository at this point in the history

  2. generalize the argument name in tests, be more specific about when fi… 

    …lename is in a different part of the multipart body
    @aoberoi
    aoberoi committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    5f00431 View commit details
    Browse the repository at this point in the history

  3. always have a filename attribute for binary content in a multipart/fo… 

    …rm-data body
    @aoberoi
    aoberoi committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    7a97825 View commit details
    Browse the repository at this point in the history