Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing properties for a dialog select element #549

Merged

Conversation

DominikPalo
Copy link
Contributor

Summary

Some properties (data_source, selected_options, option_groups and min_query_length) were missing in definitions for a dialog select element.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented May 7, 2018

Codecov Report

Merging #549 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #549   +/-   ##
=======================================
  Coverage   80.28%   80.28%           
=======================================
  Files           6        6           
  Lines         279      279           
  Branches       43       43           
=======================================
  Hits          224      224           
  Misses         38       38           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf1ae5...2bbb510. Read the comment docs.

@aoberoi
Copy link
Contributor

aoberoi commented May 7, 2018

thanks @DominikPalo, this looks great to me.

@clavin, since you last edited these lines, thoughts?

@clavin
Copy link
Contributor

clavin commented May 7, 2018

Everything looks well and good to me. 👍✨ The only thoughts I have are completely related to #496.

@aoberoi
Copy link
Contributor

aoberoi commented May 7, 2018

awesome! since this is a step in the right direction for #496, i think it should be 👌 to merge.

@aoberoi aoberoi merged commit 6317d8c into slackapi:master May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants