Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing properties for a dialog select element #549

Merged
merged 2 commits into from
May 7, 2018
Merged

Add missing properties for a dialog select element #549

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f5ffba
Add missing properties for a dialog select element
DominikPalo May 7, 2018
2bbb510
Fix semicolons
DominikPalo May 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/methods.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,14 @@ export interface Dialog {
hint?: string;
subtype?: 'email' | 'number' | 'tel' | 'url';
// type `select`:
options?: {
label: string; // shown to user
value: string; // sent to app
data_source?: 'users' | 'channels' | 'conversations' | 'external';
selected_options?: string;
options?: SelectOption[];
option_groups?: {
label: string;
options: SelectOption[];
}[];
min_query_length?: number;
}[];
submit_label?: string;
notify_on_cancel?: boolean;
Expand Down Expand Up @@ -100,6 +104,11 @@ export interface LinkUnfurls {
[linkUrl: string]: MessageAttachment;
}

export interface SelectOption {
label: string; // shown to user
value: string; // sent to app
}

/*
* MethodArguments types (no formal relationship other than the generic constraint in Method<>)
*/
Expand Down