Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTMClient.start options is optional #567

Merged
merged 1 commit into from
May 31, 2018

Conversation

christophehurpeau
Copy link
Contributor

Summary

Update typescript RTMClient.start options to be optional

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented May 25, 2018

CLA assistant check
All committers have signed the CLA.

@aoberoi
Copy link
Contributor

aoberoi commented May 25, 2018

thanks!

@codecov
Copy link

codecov bot commented May 31, 2018

Codecov Report

Merging #567 into master will increase coverage by 2.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
+ Coverage   81.72%   84.38%   +2.66%     
==========================================
  Files           6        6              
  Lines         279      333      +54     
  Branches       43       52       +9     
==========================================
+ Hits          228      281      +53     
- Misses         36       39       +3     
+ Partials       15       13       -2
Impacted Files Coverage Δ
src/WebClient.ts 88% <0%> (+3.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deafed7...a91d397. Read the comment docs.

@aoberoi aoberoi merged commit 97e2456 into slackapi:master May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants