diff --git a/README.md b/README.md index 6d02f1efc..d004fe8a6 100644 --- a/README.md +++ b/README.md @@ -99,7 +99,7 @@ Enforces having `declare(strict_types = 1)` at the top of each PHP file. Allows Sniff provides the following settings: -* `newlinesCountBetweenOpenTagAndDeclare`: allows to set 0 to N newlines to be between `addFixableError( 'There must be a single space between the PHP open tag and declare statement.', $declarePointer, - self::CODE_INCORRECT_WHITESPACE_BETWEEN_OPEN_TAG_AND_DECLARE + self::CODE_INCORRECT_WHITESPACE_BEFORE_DECLARE ); if ($fix) { $phpcsFile->fixer->beginChangeset(); @@ -183,12 +183,12 @@ public function process(File $phpcsFile, $openTagPointer): void if ($newlinesCountBefore !== $requiredNewlinesCountBetweenOpenTagAndDeclare) { $fix = $phpcsFile->addFixableError( sprintf( - 'Expected %d newlines between PHP open tag and declare statement, found %d.', + 'Expected %d newlines before declare statement, found %d.', $requiredNewlinesCountBetweenOpenTagAndDeclare, $newlinesCountBefore ), $declarePointer, - self::CODE_INCORRECT_WHITESPACE_BETWEEN_OPEN_TAG_AND_DECLARE + self::CODE_INCORRECT_WHITESPACE_BEFORE_DECLARE ); if ($fix) { $phpcsFile->fixer->beginChangeset(); diff --git a/tests/Sniffs/TypeHints/DeclareStrictTypesSniffTest.php b/tests/Sniffs/TypeHints/DeclareStrictTypesSniffTest.php index 7c9c9a456..7922bde88 100644 --- a/tests/Sniffs/TypeHints/DeclareStrictTypesSniffTest.php +++ b/tests/Sniffs/TypeHints/DeclareStrictTypesSniffTest.php @@ -105,7 +105,7 @@ public function testDeclareStrictTwoNewlinesBeforeError(): void self::assertSniffError( $report, 3, - DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BETWEEN_OPEN_TAG_AND_DECLARE, + DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BEFORE_DECLARE, 'There must be a single space between the PHP open tag and declare statement.' ); } @@ -137,8 +137,8 @@ public function testDeclareStrictOneSpaceError(): void self::assertSniffError( $report, 1, - DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BETWEEN_OPEN_TAG_AND_DECLARE, - 'Expected 2 newlines between PHP open tag and declare statement, found 0.' + DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BEFORE_DECLARE, + 'Expected 2 newlines before declare statement, found 0.' ); } @@ -166,7 +166,7 @@ public function testFixableNoNewLinesBefore(): void { $report = self::checkFile(__DIR__ . '/data/fixableDeclareStrictTypesNoNewLinesBefore.php', [ 'newlinesCountBetweenOpenTagAndDeclare' => 0, - ], [DeclareStrictTypesSniff::CODE_DECLARE_STRICT_TYPES_MISSING, DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BETWEEN_OPEN_TAG_AND_DECLARE]); + ], [DeclareStrictTypesSniff::CODE_DECLARE_STRICT_TYPES_MISSING, DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BEFORE_DECLARE]); self::assertAllFixedInFile($report); } @@ -174,7 +174,7 @@ public function testFixableMissingNoNewLines(): void { $report = self::checkFile(__DIR__ . '/data/fixableDeclareStrictTypesMissingNoNewLines.php', [ 'newlinesCountBetweenOpenTagAndDeclare' => 0, - ], [DeclareStrictTypesSniff::CODE_DECLARE_STRICT_TYPES_MISSING, DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BETWEEN_OPEN_TAG_AND_DECLARE]); + ], [DeclareStrictTypesSniff::CODE_DECLARE_STRICT_TYPES_MISSING, DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BEFORE_DECLARE]); self::assertAllFixedInFile($report); } @@ -182,7 +182,7 @@ public function testFixableOneNewLineBefore(): void { $report = self::checkFile(__DIR__ . '/data/fixableDeclareStrictTypesOneNewLineBefore.php', [ 'newlinesCountBetweenOpenTagAndDeclare' => 1, - ], [DeclareStrictTypesSniff::CODE_DECLARE_STRICT_TYPES_MISSING, DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BETWEEN_OPEN_TAG_AND_DECLARE]); + ], [DeclareStrictTypesSniff::CODE_DECLARE_STRICT_TYPES_MISSING, DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BEFORE_DECLARE]); self::assertAllFixedInFile($report); } @@ -190,7 +190,7 @@ public function testFixableMissingOneNewLine(): void { $report = self::checkFile(__DIR__ . '/data/fixableDeclareStrictTypesMissingOneNewLine.php', [ 'newlinesCountBetweenOpenTagAndDeclare' => 1, - ], [DeclareStrictTypesSniff::CODE_DECLARE_STRICT_TYPES_MISSING, DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BETWEEN_OPEN_TAG_AND_DECLARE]); + ], [DeclareStrictTypesSniff::CODE_DECLARE_STRICT_TYPES_MISSING, DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BEFORE_DECLARE]); self::assertAllFixedInFile($report); } @@ -198,7 +198,7 @@ public function testFixableMoreNewLinesBefore(): void { $report = self::checkFile(__DIR__ . '/data/fixableDeclareStrictTypesMoreNewLinesBefore.php', [ 'newlinesCountBetweenOpenTagAndDeclare' => 4, - ], [DeclareStrictTypesSniff::CODE_DECLARE_STRICT_TYPES_MISSING, DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BETWEEN_OPEN_TAG_AND_DECLARE]); + ], [DeclareStrictTypesSniff::CODE_DECLARE_STRICT_TYPES_MISSING, DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BEFORE_DECLARE]); self::assertAllFixedInFile($report); } @@ -206,7 +206,7 @@ public function testFixableMissingMoreNewLines(): void { $report = self::checkFile(__DIR__ . '/data/fixableDeclareStrictTypesMissingMoreNewLines.php', [ 'newlinesCountBetweenOpenTagAndDeclare' => 4, - ], [DeclareStrictTypesSniff::CODE_DECLARE_STRICT_TYPES_MISSING, DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BETWEEN_OPEN_TAG_AND_DECLARE]); + ], [DeclareStrictTypesSniff::CODE_DECLARE_STRICT_TYPES_MISSING, DeclareStrictTypesSniff::CODE_INCORRECT_WHITESPACE_BEFORE_DECLARE]); self::assertAllFixedInFile($report); }